New adapter: Adhese #3384
New adapter: Adhese #3384
Conversation
|
docs PR prebid/prebid.github.io#1063 |
There was a problem hiding this comment.
Hi @mefjush
Could you make some changes to the layout of the adapter file?
There are a number of what would normally be internal functions attached to the spec object (eg mergeTargets & bidToSlotName). We'd ask that you only include the expected/established functions to the spec object (see list here in the examples) and not expose these other functions.
If you have an explicit reason for structuring the file in this manner, please let us know.
|
@mefjush Thanks for making the updates to the various functions in the adapter file. When I was trying to test the updated adapter with the test params in the .md file, I wasn't getting any bids back from your server. Below is a copy of the ad request's GET url: Can you take a look to see if something is amiss? Ideally we'd like to see a working test bid while reviewing new adapters to ensure the end-to-end is working fine. Thanks. |
|
Hi, the params in the .md file document only the syntax. The params I provided in the Pull Request header should work fine: |
|
@mefjush Thanks for clarifying that; I tried the other params and they worked fine. Would you please update the md with the working copy. If someone needs to test your adapter later, it would ideal to have the params noted in the md rather than trying to dig up an old PR. We should be good to merge once that's updated. |
|
@jsnellbaker sure makes sense, I also updated the params in the "docs" PR prebid/prebid.github.io#1063 |
* Add Adhese adapter * Support empty impressionCounters * Fix the description * Replace Object.entries with Object.keys * Cleanup * Use const instead of let * Internal functions are no longer exposed * Rename getter * Use the bid parameters pointing to the existing demo position
* Add Adhese adapter * Support empty impressionCounters * Fix the description * Replace Object.entries with Object.keys * Cleanup * Use const instead of let * Internal functions are no longer exposed * Rename getter * Use the bid parameters pointing to the existing demo position
* Add Adhese adapter * Support empty impressionCounters * Fix the description * Replace Object.entries with Object.keys * Cleanup * Use const instead of let * Internal functions are no longer exposed * Rename getter * Use the bid parameters pointing to the existing demo position
Type of change
Description of change
Adds a new adapter for integration with Adhese adserver (https://adhese.com/).
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information